test(sbom-monitor): add Dragonfly user journey acceptance test#6870
Open
jacek-rzrz wants to merge 1 commit into
Open
test(sbom-monitor): add Dragonfly user journey acceptance test#6870jacek-rzrz wants to merge 1 commit into
jacek-rzrz wants to merge 1 commit into
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
jacek-rzrz
force-pushed
the
test/osf-422/sbom-monitor-dragonfly-user-journey
branch
from
f10685a to
1bb1a19
Compare
jacek-rzrz
force-pushed
the
test/osf-422/sbom-monitor-dragonfly-user-journey
branch
3 times, most recently
from
807544c to
e2d7136
Compare
jacek-rzrz
force-pushed
the
test/osf-422/sbom-monitor-dragonfly-user-journey
branch
from
e2d7136 to
69a578d
Compare
This comment has been minimized.
This comment has been minimized.
jacek-rzrz
force-pushed
the
test/osf-422/sbom-monitor-dragonfly-user-journey
branch
from
69a578d to
96680a4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jacek-rzrz
force-pushed
the
test/osf-422/sbom-monitor-dragonfly-user-journey
branch
from
96680a4 to
91c54a4
Compare
This comment has been minimized.
This comment has been minimized.
jacek-rzrz
force-pushed
the
test/osf-422/sbom-monitor-dragonfly-user-journey
branch
from
91c54a4 to
e49f18c
Compare
This comment has been minimized.
This comment has been minimized.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
|
|
||
| describe('snyk sbom monitor', () => { | ||
| it('should successfully monitor an SBOM', async () => { | ||
| const command = `sbom test --report --experimental --file=${SBOM_FILE_PATH} --asset-name=${ASSET_NAME}`; |
There was a problem hiding this comment.
Critical Bug: Wrong command is being executed
The test is intended to test snyk sbom monitor (per the file name, describe block, test name, and PR description), but the command actually executes sbom test instead:
const command = `sbom test --report --experimental --file=${SBOM_FILE_PATH} --asset-name=${ASSET_NAME}`;This should be:
const command = `sbom monitor --experimental --file=${SBOM_FILE_PATH} --asset-name=${ASSET_NAME}`;The --report flag is not needed for sbom monitor as monitoring inherently reports to the server. This bug causes the test to validate the wrong CLI functionality entirely, making it fail to test the Dragonfly SBOM monitor flow as intended.
Suggested change
| const command = `sbom test --report --experimental --file=${SBOM_FILE_PATH} --asset-name=${ASSET_NAME}`; | |
| const command = `sbom monitor --experimental --file=${SBOM_FILE_PATH} --asset-name=${ASSET_NAME}`; |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
Co-authored-by: Jacek Rzeniewicz <jacek@rzrz.pl> Co-authored-by: Sara Regan <sara.regan@snyk.io> Co-authored-by: Oana Andrisoaei <oana.andrisoaei@snyk.io>
jacek-rzrz
force-pushed
the
test/osf-422/sbom-monitor-dragonfly-user-journey
branch
from
e49f18c to
9541f8e
Compare
PR Reviewer Guide 🔍
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a real-server acceptance test for the SBOM monitor Dragonfly flow (
INTERNAL_SNYK_CLI_ROLLOUT_DFLY_SBOM_MONITOR), following the same pattern as the existingsbom testreachability user journey test — no fake server, runs against the real Snyk API usingprocess.envcredentials.Also renames
all-projects.spec.ts→beta-all-projects.spec.tsto distinguish the mocked-server beta tests from this new user journey suite.Relates to OSF-422.